Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added synthetic beans for the managed ExecutorService backed by virtual threads #36248

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Added synthetic beans for the managed ExecutorService backed by virtual threads #36248

merged 2 commits into from
Oct 17, 2023

Conversation

ozangunalp
Copy link
Contributor

@ozangunalp ozangunalp commented Oct 2, 2023 •
edited
Loading

  • Shutdown operations on the VT ThreadPerTask Executor throws runtime exception
  • Simplified the Thread per Task Executor creation
  • Configured the UncaughtExceptionHandler
  • Added a section to VT guide for injecting the ExecutorService

@ozangunalp ozangunalp mentioned this pull request Oct 2, 2023
Closed
@ozangunalp ozangunalp force-pushed the vthreads_executor_beans branch 2 times, most recently from fa2e4d7 to 58f1cdf Compare October 6, 2023 15:09
@ozangunalp ozangunalp marked this pull request as ready for review October 6, 2023 15:10
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba added the area/virtual-threads Issue related to Java's Virtual Threads label Oct 13, 2023
@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier
Copy link
Member

@ozangunalp can you rebase so we know if the CI is going to be insane again?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 16, 2023

Failing Jobs - Building d5ba035

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✖ JVM Tests - JDK 20 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
✖ Native Tests - Windows - RESTEasy Jackson Setup GraalVM ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/oidc-client-graphql/deployment

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientAnnotation - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-graphql/deployment

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientWithDefault - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ JVM Tests - JDK 20 #

- Failing: extensions/oidc-client-graphql/deployment

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@cescoffier
Copy link
Member

Ok, the CI issues are back to the regular ones.

@cescoffier cescoffier merged commit f62e45b into quarkusio:main Oct 17, 2023
49 of 54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 17, 2023
@ozangunalp ozangunalp deleted the vthreads_executor_beans branch October 17, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba left review comments

@gastaldi gastaldi gastaldi approved these changes

@cescoffier cescoffier cescoffier approved these changes

@Ladicek Ladicek Awaiting requested review from Ladicek

Assignees
No one assigned
Labels
area/documentation area/virtual-threads Issue related to Java's Virtual Threads
Projects
Quarkus Documentation
Status: Done
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@ozangunalp @cescoffier @gastaldi @Ladicek @mkouba